revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 11:30:55 +01:00
Code Issues Releases Wiki Activity

Add basic diff coloring to CelerityDefaultProcessor

Browse source 
Summary: Moves basic colors into the processor.

Test Plan: Review a diff in sandbox with and without change.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17173
This commit is contained in:
Chad Little 2017-01-10 14:45:58 -08:00
parent 52d563f8b8
commit 1e1a0182ca
3 changed files with 22 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/celerity/map.php
View file

@ -12,7 +12,7 @@ return array(
'core.pkg.css' => '9c725fa0', 'core.pkg.css' => '9c725fa0',
'core.pkg.js' => 'a2ead3fe', 'core.pkg.js' => 'a2ead3fe',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'e0517745', 'differential.pkg.css' => '9535a7e6',
'differential.pkg.js' => '40b18f35', 'differential.pkg.js' => '40b18f35',
'diffusion.pkg.css' => '91c5d3a6', 'diffusion.pkg.css' => '91c5d3a6',
'diffusion.pkg.js' => '84c8f8fd', 'diffusion.pkg.js' => '84c8f8fd',
@ -59,7 +59,7 @@ return array(
'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127', 'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a', 'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
'rsrc/css/application/differential/changeset-view.css' => 'a5a96310', 'rsrc/css/application/differential/changeset-view.css' => 'e1621fd5',
'rsrc/css/application/differential/core.css' => '5b7b8ff4', 'rsrc/css/application/differential/core.css' => '5b7b8ff4',
'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e', 'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
'rsrc/css/application/differential/revision-comment.css' => '14b8565a', 'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
@ -574,7 +574,7 @@ return array(
'conpherence-thread-manager' => 'c8b5ee6f', 'conpherence-thread-manager' => 'c8b5ee6f',
'conpherence-transaction-css' => '85129c68', 'conpherence-transaction-css' => '85129c68',
'd3' => 'a11a5ff2', 'd3' => 'a11a5ff2',
'differential-changeset-view-css' => 'a5a96310', 'differential-changeset-view-css' => 'e1621fd5',
'differential-core-view-css' => '5b7b8ff4', 'differential-core-view-css' => '5b7b8ff4',
'differential-inline-comment-editor' => '2e3f9738', 'differential-inline-comment-editor' => '2e3f9738',
'differential-revision-add-comment-css' => 'c47f8c40', 'differential-revision-add-comment-css' => 'c47f8c40',
@ -1756,9 +1756,6 @@ return array(
'javelin-uri', 'javelin-uri',
'phabricator-notification', 'phabricator-notification',
), ),
'a5a96310' => array(
'phui-inline-comment-view-css',
),
'a5c57c24' => array( 'a5c57c24' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-stratcom', 'javelin-stratcom',
@ -2094,6 +2091,9 @@ return array(
'javelin-dom', 'javelin-dom',
'phabricator-prefab', 'phabricator-prefab',
), ),
'e1621fd5' => array(
'phui-inline-comment-view-css',
),
'e1d25dfb' => array( 'e1d25dfb' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-stratcom', 'javelin-stratcom',

8
src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php
View file

@ -192,6 +192,14 @@ final class CelerityDefaultPostprocessor
'sh-disabledtext' => '#a6a6a6', 'sh-disabledtext' => '#a6a6a6',
'sh-disabledbackground' => '#f3f3f3', 'sh-disabledbackground' => '#f3f3f3',
// Diffs
'new-background' => '#eaffea',
'new-bright' => '#a6f3a6',
'old-background' => '#ffecec',
'old-bright' => '#f8cbcb',
'move-background' => '#fdf5d4',
'copy-background' => '#f1c40f',
// Background color for "most" themes. // Background color for "most" themes.
'page.background' => '#f8f8fb', 'page.background' => '#f8f8fb',
'page.sidenav' => '#f0f0f2', 'page.sidenav' => '#f0f0f2',

16
webroot/rsrc/css/application/differential/changeset-view.css
View file

@ -122,19 +122,19 @@
} }
.differential-diff th.old { .differential-diff th.old {
border-right-color: #f8cbcb; border-right-color: {$old-bright};
} }
.differential-diff th.new { .differential-diff th.new {
border-right-color: #a6f3a6; border-right-color: {$new-bright};
} }
.differential-diff td.old { .differential-diff td.old {
background: #ffecec; background: {$old-background};
} }
.differential-diff td.new { .differential-diff td.new {
background: #eaffea; background: {$new-background};
} }
.differential-diff td.old-rebase { .differential-diff td.old-rebase {
@ -148,13 +148,13 @@
.differential-diff td.old span.bright, .differential-diff td.old span.bright,
.differential-diff td.old-full, .differential-diff td.old-full,
.prose-diff span.old { .prose-diff span.old {
background: #f8cbcb; background: {$old-bright};
} }
.differential-diff td.new span.bright, .differential-diff td.new span.bright,
.differential-diff td.new-full, .differential-diff td.new-full,
.prose-diff span.new { .prose-diff span.new {
background: #a6f3a6; background: {$new-bright};
} }
.differential-diff td.copy { .differential-diff td.copy {
@ -165,12 +165,12 @@
.differential-diff td.new-copy, .differential-diff td.new-copy,
.differential-diff td.new-copy span.bright { .differential-diff td.new-copy span.bright {
background: {$lightyellow}; background: {$copy-background};
} }
.differential-diff td.new-move, .differential-diff td.new-move,
.differential-diff td.new-move span.bright { .differential-diff td.new-move span.bright {
background: {$yellow}; background: {$move-background};
} }
.differential-diff td.comment { .differential-diff td.comment {