Change spacing, layout of ObjectItem states

Summary:
A few tweaks:

 - Height in box is consistent now at 50px an Object
 - Divider/rule extends full width of box
 - Icon centers inside rule, box area.

Test Plan:
Test UIExamples, check spacing with 4px grid in Photoshop. Test mobile/desktop layout of Harbormaster.

{F149599}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8929

resources/celerity/map.php

@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => 'cc50ddf5',
+    'core.pkg.css' => 'cd6367eb',
     'core.pkg.js' => '417722ff',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '8a064eb7',
@@ -137,7 +137,7 @@ return array(
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
     'rsrc/css/phui/phui-list.css' => 'ef8035b6',
     'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
-    'rsrc/css/phui/phui-object-item-list-view.css' => 'c11ec980',
+    'rsrc/css/phui/phui-object-item-list-view.css' => '574faec3',
     'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
     'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
     'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
@@ -761,7 +761,7 @@ return array(
     'phui-info-panel-css' => '27ea50a1',
     'phui-list-view-css' => 'ef8035b6',
     'phui-object-box-css' => 'ce92d8ec',
-    'phui-object-item-list-view-css' => 'c11ec980',
+    'phui-object-item-list-view-css' => '574faec3',
     'phui-pinboard-view-css' => '4b346c2a',
     'phui-property-list-view-css' => 'c4d44192',
     'phui-remarkup-preview-css' => '19ad512b',

src/applications/uiexample/examples/PHUIObjectItemListExample.php

@@ -398,6 +398,14 @@ final class PHUIObjectItemListExample extends PhabricatorUIExample {
         ->setHref('#')
         ->setState(PHUIObjectItemView::STATE_NOTE));
 
+    $list->addItem(
+      id(new PHUIObjectItemView())
+        ->setObjectName('X1203')
+        ->setHeader(pht('Action In Progress'))
+        ->addAttribute(pht('Outlook fuzzy, try again later'))
+        ->setHref('#')
+        ->setState(PHUIObjectItemView::STATE_BUILD));
+
     $box = id(new PHUIObjectBoxView())
       ->setHeaderText('Test Things')
       ->appendChild($list);

webroot/rsrc/css/phui/phui-object-item-list-view.css

@@ -608,20 +608,25 @@
 .phui-object-item-ficon {
   width: 26px;
   height: 26px;
-  margin: 7px 9px 7px 0;
+  margin: 11px 9px 7px 12px;
   position: absolute;
 }
 
+.device-desktop .phui-object-list-states .phui-object-item {
+  margin: 0;
+}
+
 .phui-object-item-with-ficon .phui-object-item-content-box {
-  margin-left: 24px;
+  margin-left: 38px;
 }
 
 .phui-object-box .phui-object-list-states {
-  padding: 8px 12px 0 12px;
+  padding: 0;
 }
 
 .phui-object-box .phui-object-list-states li:last-child .phui-object-item-frame {
   border: none;
+  padding-bottom: 0;
 }
 
 .phui-object-list-states .phui-object-item-frame {