From 1e9120cdfb3da7eb8ea43aa1aac89eac4945d52a Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 24 Jul 2012 07:37:41 -0700 Subject: [PATCH] Minor, fix an issue in Diffusion/Herald with commits that have no Auditors. --- .../worker/PhabricatorRepositoryCommitHeraldWorker.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php index 8e0a93bc10..38e6a3bf92 100644 --- a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php +++ b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php @@ -222,7 +222,7 @@ final class PhabricatorRepositoryCommitHeraldWorker $matches = null; if (!preg_match('/^Auditors:\s*(.*)$/im', $message, $matches)) { - return; + return array(); } $phids = DifferentialFieldSpecification::parseCommitMessageObjectList( @@ -231,7 +231,7 @@ final class PhabricatorRepositoryCommitHeraldWorker $allow_partial = true); if (!$phids) { - return; + return array(); } $requests = id(new PhabricatorRepositoryAuditRequest())->loadAllWhere(