revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Keep setIcon() working for now on PHUIObjectItemView

Browse source 
Summary:
Ref T11501. This method was removed in D16418, but still has some callsites. I know of four:

  - Config
  - Settings
  - Drydock main page
  - Almanac main page

Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly.

Test Plan: Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11501

Differential Revision: https://secure.phabricator.com/D16420
This commit is contained in:
epriestley 2016-08-19 04:52:43 -07:00
parent 1cca7fbcce
commit 1ecce60589
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/view/phui/PHUIObjectItemView.php
View file

@ -167,6 +167,11 @@ final class PHUIObjectItemView extends AphrontTagView {
return $this;
}
public function setIcon($icon) {
// TODO: Remove this in favor of setStatusIcon()?
return $this->setStatusIcon($icon);
}
public function setStatusIcon($icon, $label = null) {
$this->statusIcon = array(
'icon' => $icon,