revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Put application curtain panels above extension curtain panels

Browse source 
Summary:
Ref T13528. The original rationale here was that it's easier to find items at the bottom of the curtain than somewhere in the middle, since they're in a more clearly predictable visual location.

This might be true in some sense, but user feedback about this has fairly consistently indicated that the layout is surprising. Try the other order. See also D20967 for some discussion.

In practice, this primarily moves "Author / Assigned" above other panel elements in Maniphest.

Test Plan: Looked at tasks, aw "Author / Assigned" above "Tags / Subscribers".

Maniphest Tasks: T13528

Differential Revision: https://secure.phabricator.com/D21200
This commit is contained in:
epriestley 2020-05-01 07:22:55 -07:00
parent d6928a3c26
commit 1edca1ee2a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/view/layout/PHUICurtainView.php
View file

@ -19,9 +19,9 @@ final class PHUICurtainView extends AphrontTagView {
$panel = new PHUICurtainPanelView();
$this->addPanel($panel);
// By default, application panels go at the bottom of the curtain, below
// By default, application panels go at the top of the curtain, above
// extension panels.
$panel->setOrder(100000);
$panel->setOrder(1000);
return $panel;
}