1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00

Allow lint messages to be rendered as Remarkup

Summary: Some linter messages, such as those produced by `ArcanistPHPCompatibilityXHPASTLinterRule`, contain backticks but are currently rendered as Remarkup literals. I think that it is generally desirable to allow lint messages to be rendered as Remarkup, although we should ideally have a way to render Remarkup for use on the command line (I actually think that this already exists, but I don't think that `arc lint` does this when rendering linter messages).

Test Plan: Resubmitted D14481 to my dev install and saw Remarkuped lint messages.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14485
This commit is contained in:
Joshua Spence 2015-11-15 19:50:10 +00:00 committed by joshuaspence
parent ca0b36c174
commit 1f1c3f4075
2 changed files with 3 additions and 7 deletions

View file

@ -387,7 +387,6 @@ final class DifferentialChangesetViewController extends DifferentialController {
$inlines = array();
foreach ($messages as $message) {
$description = $message->getProperty('description');
$description = '%%%'.$description.'%%%';
$inlines[] = id(clone $template)
->setSyntheticAuthor(pht('Lint: %s', $message->getName()))

View file

@ -227,9 +227,7 @@ final class PHUIDiffInlineCommentDetailView
$action_buttons = array();
if ($this->allowReply) {
if (!$is_synthetic) {
// NOTE: No product reason why you can't reply to these, but the reply
// mechanism currently sends the inline comment ID to the server, not
// file/line information, and synthetic comments don't have an inline
@ -242,7 +240,6 @@ final class PHUIDiffInlineCommentDetailView
->addSigil('differential-inline-reply')
->setMustCapture(true);
}
}
}
@ -267,11 +264,11 @@ final class PHUIDiffInlineCommentDetailView
$links[] = javelin_tag(
'a',
array(
'class' => 'inline-button-divider pml msl',
'meta' => array(
'class' => 'inline-button-divider pml msl',
'meta' => array(
'anchor' => $anchor_name,
),
'sigil' => 'differential-inline-preview-jump',
'sigil' => 'differential-inline-preview-jump',
),
pht('Not Visible'));