1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00

Render valid HTML

Summary: Also delete some dead code.

Test Plan: /D1

Reviewers: tuomaspelkonen, epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2120
This commit is contained in:
vrana 2012-04-06 01:32:05 -07:00
parent 6aa729b1c9
commit 1f2028adf0
2 changed files with 7 additions and 5 deletions

View file

@ -174,8 +174,13 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
$rows[] = $rows[] =
'<tr>'. '<tr>'.
'<td class="differential-toc-char" title='.$chartitle.'>'.$char. phutil_render_tag(
'</td>'. 'td',
array(
'class' => 'differential-toc-char',
'title' => $chartitle,
),
$char).
'<td class="differential-toc-prop">'.$pchar.'</td>'. '<td class="differential-toc-prop">'.$pchar.'</td>'.
'<td class="differential-toc-ftype">'.$desc.'</td>'. '<td class="differential-toc-ftype">'.$desc.'</td>'.
'<td class="differential-toc-file">'.$link.$lines.'</td>'. '<td class="differential-toc-file">'.$link.$lines.'</td>'.

View file

@ -34,9 +34,6 @@ final class DiffusionCommitChangeTableView extends DiffusionView {
// TODO: Copy Away and Move Away are rendered junkily still. // TODO: Copy Away and Move Away are rendered junkily still.
foreach ($this->pathChanges as $change) { foreach ($this->pathChanges as $change) {
$change_verb = DifferentialChangeType::getFullNameForChangeType(
$change->getChangeType());
$path = $change->getPath(); $path = $change->getPath();
$hash = substr(md5($path), 0, 8); $hash = substr(md5($path), 0, 8);
if ($change->getFileType() == DifferentialChangeType::FILE_DIRECTORY) { if ($change->getFileType() == DifferentialChangeType::FILE_DIRECTORY) {