1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-09 16:32:39 +01:00

Fix repository URI generation for SVN commit identifiers represented with integer types

Summary:
Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in `phutil_nonempty_string()`, which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan: Will deploy.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21852
This commit is contained in:
epriestley 2022-06-03 14:26:34 -07:00
parent 944b257d5d
commit 1fc04e238f

View file

@ -752,7 +752,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
}
$raw_commit = $commit;
if (phutil_nonempty_string($commit)) {
if (phutil_nonempty_scalar($commit)) {
$commit = str_replace('$', '$$', $commit);
$commit = ';'.phutil_escape_uri($commit);
}