From 20446252ff422bddd00cbed008aa1cb53bc41062 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 2 Jul 2014 04:59:15 -0700 Subject: [PATCH] Add a header warning to revisions that need a legal document signature Summary: This supplements the footer warning and makes it more visible for authors. Test Plan: {F173277} Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D9794 --- .../DifferentialRequiredSignaturesField.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php b/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php index 809d60573c..0daddf40cb 100644 --- a/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php +++ b/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php @@ -130,5 +130,17 @@ final class DifferentialRequiredSignaturesField return false; } + public function getWarningsForRevisionHeader(array $handles) { + if (!$this->haveAnyUnsignedDocuments()) { + return array(); + } + + return array( + pht( + 'This revision can not be accepted until the required legal '. + 'agreements have been signed.'), + ); + } + }