revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 20:10:55 +01:00
Code Issues Releases Wiki Activity

Render Remarkup in emails

Browse source 
Summary: Ref T992. I noticed that `ManiphestTask` mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I //think// this is because the code calls `addTextSection()` rather than `addRemarkupSection()`.

Test Plan: Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with `./bin/mail show-outbound`). I didn't test the other affected applications.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T992

Differential Revision: https://secure.phabricator.com/D14511
This commit is contained in:
Joshua Spence 2015-11-24 06:43:00 +11:00
parent df7f21b4e8
commit 2047483cc0
11 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/audit/editor/PhabricatorAuditEditor.php
View file

@ -660,7 +660,7 @@ final class PhabricatorAuditEditor
} }
if ($inlines) { if ($inlines) {
$body->addTextSection( $body->addRemarkupSection(
pht('INLINE COMMENTS'), pht('INLINE COMMENTS'),
$this->renderInlineCommentsForMail($object, $inlines)); $this->renderInlineCommentsForMail($object, $inlines));
} }

2
src/applications/badges/editor/PhabricatorBadgesEditor.php
View file

@ -194,7 +194,7 @@ final class PhabricatorBadgesEditor
$body = parent::buildMailBody($object, $xactions); $body = parent::buildMailBody($object, $xactions);
if (strlen($description)) { if (strlen($description)) {
$body->addTextSection( $body->addRemarkupSeciton(
pht('BADGE DESCRIPTION'), pht('BADGE DESCRIPTION'),
$object->getDescription()); $object->getDescription());
} }

2
src/applications/countdown/editor/PhabricatorCountdownEditor.php
View file

@ -173,7 +173,7 @@ final class PhabricatorCountdownEditor
$description = $object->getDescription(); $description = $object->getDescription();
if (strlen($description)) { if (strlen($description)) {
$body->addTextSection( $body->addRemarkupSection(
pht('COUNTDOWN DESCRIPTION'), pht('COUNTDOWN DESCRIPTION'),
$object->getDescription()); $object->getDescription());
} }

2
src/applications/differential/customfield/DifferentialSummaryField.php
View file

@ -165,7 +165,7 @@ final class DifferentialSummaryField
return; return;
} }
$body->addTextSection(pht('REVISION SUMMARY'), $summary); $body->addRemarkupSection(pht('REVISION SUMMARY'), $summary);
} }
} }

2
src/applications/differential/customfield/DifferentialTestPlanField.php
View file

@ -195,7 +195,7 @@ final class DifferentialTestPlanField
return; return;
} }
$body->addTextSection(pht('TEST PLAN'), $test_plan); $body->addRemarkupSection(pht('TEST PLAN'), $test_plan);
} }

2
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -1212,7 +1212,7 @@ final class DifferentialTransactionEditor
} }
if ($inlines) { if ($inlines) {
$body->addTextSection( $body->addRemarkupSection(
pht('INLINE COMMENTS'), pht('INLINE COMMENTS'),
$this->renderInlineCommentsForMail($object, $inlines)); $this->renderInlineCommentsForMail($object, $inlines));
} }

2
src/applications/maniphest/editor/ManiphestTransactionEditor.php
View file

@ -442,7 +442,7 @@ final class ManiphestTransactionEditor
$body = parent::buildMailBody($object, $xactions); $body = parent::buildMailBody($object, $xactions);
if ($this->getIsNewObject()) { if ($this->getIsNewObject()) {
$body->addTextSection( $body->addRemarkupSection(
pht('TASK DESCRIPTION'), pht('TASK DESCRIPTION'),
$object->getDescription()); $object->getDescription());
} }

2
src/applications/phriction/editor/PhrictionTransactionEditor.php
View file

@ -419,7 +419,7 @@ final class PhrictionTransactionEditor
$body = parent::buildMailBody($object, $xactions); $body = parent::buildMailBody($object, $xactions);
if ($this->getIsNewObject()) { if ($this->getIsNewObject()) {
$body->addTextSection( $body->addRemarkupSection(
pht('DOCUMENT CONTENT'), pht('DOCUMENT CONTENT'),
$object->getContent()->getContent()); $object->getContent()->getContent());
} else if ($this->contentDiffURI) { } else if ($this->contentDiffURI) {

2
src/applications/phurl/editor/PhabricatorPhurlURLEditor.php
View file

@ -236,7 +236,7 @@ final class PhabricatorPhurlURLEditor
$body = parent::buildMailBody($object, $xactions); $body = parent::buildMailBody($object, $xactions);
if (strlen($description)) { if (strlen($description)) {
$body->addTextSection( $body->addRemarkupSection(
pht('URL DESCRIPTION'), pht('URL DESCRIPTION'),
$object->getDescription()); $object->getDescription());
} }

2
src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
View file

@ -249,7 +249,7 @@ final class ReleephRequestTransactionalEditor
if ($has_pick_failure) { if ($has_pick_failure) {
$instructions = $releeph_project->getDetail('pick_failure_instructions'); $instructions = $releeph_project->getDetail('pick_failure_instructions');
if ($instructions) { if ($instructions) {
$body->addTextSection( $body->addRemarkupSection(
pht('PICK FAILURE INSTRUCTIONS'), pht('PICK FAILURE INSTRUCTIONS'),
$instructions); $instructions);
} }

2
src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
View file

@ -145,7 +145,7 @@ final class PhabricatorSlowvoteEditor
$description = $object->getDescription(); $description = $object->getDescription();
if (strlen($description)) { if (strlen($description)) {
$body->addTextSection( $body->addRemarkupSection(
pht('SLOWVOTE DESCRIPTION'), pht('SLOWVOTE DESCRIPTION'),
$object->getDescription()); $object->getDescription());
} }