revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Fix PhabricatorBot ignore messages from senders

Browse source 
Summary:
PhabricatorBotMessage->getSender returns a PhabricatorBotUser object (which potentially can be null)
So check null and then use getName to get actual name of the sender

Test Plan: Run phabot and add myself to ignore list

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5036
This commit is contained in:
John Watson 2013-02-20 12:30:06 -08:00 committed by epriestley
parent 28bdeb6d3e
commit 204d6481e4
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/infrastructure/daemon/bot/PhabricatorBot.php
View file

@ -107,8 +107,11 @@ final class PhabricatorBot extends PhabricatorDaemon {
private function routeMessage(PhabricatorBotMessage $message) { private function routeMessage(PhabricatorBotMessage $message) {
$ignore = $this->getConfig('ignore'); $ignore = $this->getConfig('ignore');
if ($ignore && in_array($message->getSender(), $ignore)) { if ($ignore) {
return; $sender = $message->getSender();
if ($sender && in_array($sender->getName(), $ignore)) {
return;
}
} }
foreach ($this->handlers as $handler) { foreach ($this->handlers as $handler) {