1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00

Fix some issues with new Conduit method implementations

Summary: Ref T5655. A few of these were missed.

Test Plan:
Checked all other methods like this:

```
    foreach ($method_map as $k => $v) {
      $v = preg_replace('/ConduitAPIMethod$/', '', $v);
      $k = str_replace('.', '', $k);
      $v = strtolower($v);
      if ($k != $v) {
        echo "{$k} x {$v}!\n";
      }
    }
    echo "OK\n";
```

Reviewers: hach-que, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D10049
This commit is contained in:
epriestley 2014-07-24 21:57:03 -07:00
parent bff217efd3
commit 20589389de
5 changed files with 4 additions and 5 deletions

View file

@ -172,7 +172,7 @@ final class ConduitCall {
$method = ConduitAPIMethod::getConduitMethod($method_name); $method = ConduitAPIMethod::getConduitMethod($method_name);
if (!$method) { if (!$method) {
throw new ConduitMethodNotFoundException($method); throw new ConduitMethodNotFoundException($method_name);
} }
$application = $method->getApplication(); $application = $method->getApplication();

View file

@ -96,7 +96,6 @@ abstract class ConduitAPIMethod
if ($method_map === null) { if ($method_map === null) {
$methods = id(new PhutilSymbolLoader()) $methods = id(new PhutilSymbolLoader())
->setAncestorClass(__CLASS__) ->setAncestorClass(__CLASS__)
->setConcreteOnly(true)
->loadObjects(); ->loadObjects();
foreach ($methods as $method) { foreach ($methods as $method) {

View file

@ -4,7 +4,7 @@ final class DiffusionResolveRefsConduitAPIMethod
extends DiffusionQueryConduitAPIMethod { extends DiffusionQueryConduitAPIMethod {
public function getAPIMethodName() { public function getAPIMethodName() {
return 'differential.resolverefsquery'; return 'diffusion.resolverefs';
} }
public function getMethodDescription() { public function getMethodDescription() {

View file

@ -4,7 +4,7 @@ final class DiffusionSearchQueryConduitAPIMethod
extends DiffusionQueryConduitAPIMethod { extends DiffusionQueryConduitAPIMethod {
public function getAPIMethodName() { public function getAPIMethodName() {
return 'differential.searchquery'; return 'diffusion.searchquery';
} }
public function getMethodDescription() { public function getMethodDescription() {

View file

@ -4,7 +4,7 @@ final class DiffusionTagsQueryConduitAPIMethod
extends DiffusionQueryConduitAPIMethod { extends DiffusionQueryConduitAPIMethod {
public function getAPIMethodName() { public function getAPIMethodName() {
return 'differential.tagsquery'; return 'diffusion.tagsquery';
} }
public function getMethodDescription() { public function getMethodDescription() {