revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
Code Issues Releases Wiki Activity

Remove tests for JX.$.NotFound from Phabricator

Browse source 
Summary: See D939. Regardless of what we do there, these will break, and they're
pretty silly anyway (see the giant caveat comments in the second one).

Test Plan: Clicked a direct-jump comment link, did save/cancel for inline
comments.

Reviewers: phil, cpojer, tomo, mroch

Reviewed By: phil

CC: aran, phil

Differential Revision: 940
This commit is contained in:
epriestley 2011-09-15 15:05:50 -07:00
parent 8396c879b1
commit 209179a74a
3 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/__celerity_resource_map__.php
View file

@ -181,7 +181,7 @@ celerity_register_resource_map(array(
), ),
'differential-inline-comment-editor' => 'differential-inline-comment-editor' =>
array( array(
'uri' => '/res/5e4f0aa4/rsrc/js/application/differential/DifferentialInlineCommentEditor.js', 'uri' => '/res/ff5f42a9/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -703,14 +703,13 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-phabricator-watch-anchor' => 'javelin-behavior-phabricator-watch-anchor' =>
array( array(
'uri' => '/res/46298448/rsrc/js/application/core/behavior-watch-anchor.js', 'uri' => '/res/96f40736/rsrc/js/application/core/behavior-watch-anchor.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
0 => 'javelin-behavior', 0 => 'javelin-behavior',
1 => 'javelin-stratcom', 1 => 'javelin-stratcom',
2 => 'javelin-util', 2 => 'javelin-dom',
3 => 'javelin-dom',
), ),
'disk' => '/rsrc/js/application/core/behavior-watch-anchor.js', 'disk' => '/rsrc/js/application/core/behavior-watch-anchor.js',
), ),

9
webroot/rsrc/js/application/core/behavior-watch-anchor.js
View file

@ -2,7 +2,6 @@
* @provides javelin-behavior-phabricator-watch-anchor * @provides javelin-behavior-phabricator-watch-anchor
* @requires javelin-behavior * @requires javelin-behavior
* javelin-stratcom * javelin-stratcom
* javelin-util
* javelin-dom * javelin-dom
*/ */
@ -14,14 +13,10 @@ JX.behavior('phabricator-watch-anchor', function() {
highlighted && JX.DOM.alterClass(highlighted, 'anchor-target', false); highlighted && JX.DOM.alterClass(highlighted, 'anchor-target', false);
try { try {
highlighted = JX.$('anchor-' + window.location.hash.replace('#', '')); highlighted = JX.$('anchor-' + window.location.hash.replace('#', ''));
JX.DOM.alterClass(highlighted, 'anchor-target', true);
} catch (ex) { } catch (ex) {
if (ex === JX.$.NotFound) { highlighted = null;
highlighted = null;
} else {
throw ex;
}
} }
highlighted && JX.DOM.alterClass(highlighted, 'anchor-target', true);
} }
// Defer invocation so other listeners can update the document. // Defer invocation so other listeners can update the document.

3
webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js
View file

@ -109,9 +109,6 @@ JX.install('DifferentialInlineCommentEditor', {
'textarea', 'textarea',
'differential-inline-comment-edit-textarea'); 'differential-inline-comment-edit-textarea');
} catch (ex) { } catch (ex) {
if (ex !== JX.$.NotFound) {
throw ex;
}
// The close handler is called whenever the dialog closes, even if the // The close handler is called whenever the dialog closes, even if the
// user closed it by completing the workflow with "Save". The // user closed it by completing the workflow with "Save". The
// JX.Workflow API should probably be refined to allow programmatic // JX.Workflow API should probably be refined to allow programmatic