revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

Settings - upgrade monospace font regexp to support '.'

Browse source 
Summary: this data is a little weird since its user-entered and we need to put it in a web page un-escaped for the font to load correctly. Ergo, we use a regex to make the input safe / sane, and said regex needs to support a '.'.  Fixes T5810.

Test Plan: added Fixedsys Excelsior 3.01 to my system and was able to set my preference and get the new font

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: dereckson, epriestley, Korvin

Maniphest Tasks: T5810

Differential Revision: https://secure.phabricator.com/D10163
This commit is contained in:
Bob Trahan 2014-08-06 13:53:30 -07:00
parent 9c1c4bb5ae
commit 20a65b21eb
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
View file

@ -32,7 +32,7 @@ final class PhabricatorSettingsPanelDisplayPreferences
$monospaced = $request->getStr($pref_monospaced); $monospaced = $request->getStr($pref_monospaced);
// Prevent the user from doing stupid things. // Prevent the user from doing stupid things.
$monospaced = preg_replace('/[^a-z0-9 ,"]+/i', '', $monospaced); $monospaced = preg_replace('/[^a-z0-9 ,".]+/i', '', $monospaced);
$preferences->setPreference($pref_titles, $request->getStr($pref_titles)); $preferences->setPreference($pref_titles, $request->getStr($pref_titles));
$preferences->setPreference($pref_editor, $request->getStr($pref_editor)); $preferences->setPreference($pref_editor, $request->getStr($pref_editor));