revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Fix a lookup issue in Owners

Browse source 
Summary:
Fixes T4477. Sort of winging this but it's probably the right fix?

One error in T4477.

One error via email:

```
[2014-04-15 17:44:34] ERROR 8: Undefined index: /some_index/ at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:213]
  #0 PhabricatorOwnersPackage::findLongestPathsPerPackage(Array of size 3 starting with: { 0 => Array of size 3 starting with: { id => 5 } }, Array of size 8 starting with: { / => Array of size 2 starting with: { /some_index/some_file.py => true } }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:170]
  #1 PhabricatorOwnersPackage::loadPackagesForPaths(Object PhabricatorRepository, Array of size 2 starting with: { 0 => /some_index/some_file.py }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:119]
...
```

Test Plan: Will make @zeeg do it.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Maniphest Tasks: T4477

Differential Revision: https://secure.phabricator.com/D8779
This commit is contained in:
epriestley 2014-04-15 11:12:42 -07:00
parent c845b757ee
commit 20abf37b88
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/owners/storage/PhabricatorOwnersPackage.php
View file

@ -210,7 +210,7 @@ final class PhabricatorOwnersPackage extends PhabricatorOwnersDAO
$remove = array(); $remove = array();
foreach ($package_paths as $package_path) { foreach ($package_paths as $package_path) {
if ($package_path['excluded']) { if ($package_path['excluded']) {
$remove += $relevant_paths[$package_path['path']]; $remove += idx($relevant_paths, $package_path['path'], array());
unset($relevant_paths[$package_path['path']]); unset($relevant_paths[$package_path['path']]);
} }
} }