mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-19 13:22:42 +01:00
Mark external -> external redirects in Phame to canonicalize URIs as "external"
Summary: Ref T9897. If you visit `/post/123/spoderman/` it will try to redirect you to `/post/123/spiderman/`, but currently only internal views work because these redirects aren't marked as safe/external. Test Plan: Visited a misspelled/out-of-date URI on an external blog view, got a good redirect. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9897 Differential Revision: https://secure.phabricator.com/D14741
This commit is contained in:
parent
9e78f33847
commit
20d2652d03
1 changed files with 8 additions and 1 deletions
|
@ -129,7 +129,14 @@ abstract class PhameLiveController extends PhameController {
|
|||
$uri = $post->getViewURI();
|
||||
}
|
||||
|
||||
return id(new AphrontRedirectResponse())->setURI($uri);
|
||||
$response = id(new AphrontRedirectResponse())
|
||||
->setURI($uri);
|
||||
|
||||
if ($is_external) {
|
||||
$response->setIsExternal(true);
|
||||
}
|
||||
|
||||
return $response;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue