From 213e4ec9b55344609f89aee20bc80af823d39b9b Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 25 Aug 2017 07:23:54 -0700 Subject: [PATCH] Add a missing (int) cast to diff IDs for new "transaction.search" method Summary: These come out of the database as strings (see T12678), force them to integers for the API. Test Plan: Called `transaction.search`, got integers in JSON instead of strings. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D18476 --- .../xaction/DifferentialRevisionInlineTransaction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php b/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php index 9e566047ec..35d5034033 100644 --- a/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php @@ -40,7 +40,7 @@ final class DifferentialRevisionInlineTransaction return array( 'diff' => array( - 'id' => $diff->getID(), + 'id' => (int)$diff->getID(), 'phid' => $diff->getPHID(), ), 'path' => $changeset->getDisplayFilename(),