From 21454842bf1817a113bfd91500b219adee8d96e2 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 28 Mar 2015 06:54:04 -0700
Subject: [PATCH] Fix comment previews in Quicksand

Summary:
Fixes T7063. Fixes T7059. We were running some extra unnecessary behaviors. In particular, we would render the menu but not actually send it over the wire, so some behaviors would execute, fail to find the nodes they expected, and throw. This cascaded into some other failures.

Do less work and don't activate behaviors which won't be able to run.

Test Plan: Clicked around, no more errors on page transition. Comment previews work.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7059, T7063

Differential Revision: https://secure.phabricator.com/D12188
---
 src/view/page/PhabricatorStandardPageView.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
index 5c5b750a20..61709265f4 100644
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -590,9 +590,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView {
   }
 
   public function renderForQuicksand() {
-    // TODO: We could run a lighter version of this and skip some work. In
-    // particular, we end up including many redundant resources.
-    $this->willRenderPage();
+    parent::willRenderPage();
     $response = $this->renderPageBodyContent();
     $response = $this->willSendResponse($response);