revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-21 13:00:56 +01:00
Code Issues Releases Wiki Activity

Transactions - fix bug adding people to projects

Browse source 
Summary: Fixes T8264. Broken in D12929. Sweep all the applyBuiltin implementations and always break; rather than return

Test Plan: added myself to a project successfully (showed up as a member)

Reviewers: epriestley, chad

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403, T8264

Differential Revision: https://secure.phabricator.com/D12940
This commit is contained in:
Bob Trahan 2015-05-19 15:22:41 -07:00
parent c896aeb62e
commit 2154f17b3d
3 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/audit/editor/PhabricatorAuditEditor.php
View file

@ -200,7 +200,7 @@ final class PhabricatorAuditEditor
$state, $state,
$phid); $phid);
} }
return; break;
} }
return parent::applyBuiltinExternalTransaction($object, $xaction); return parent::applyBuiltinExternalTransaction($object, $xaction);

2
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -609,7 +609,7 @@ final class DifferentialTransactionEditor
$state, $state,
$phid); $phid);
} }
return; break;
} }
return parent::applyBuiltinExternalTransaction($object, $xaction); return parent::applyBuiltinExternalTransaction($object, $xaction);

6
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
View file

@ -163,11 +163,7 @@ final class PhabricatorProjectTransactionEditor
PhabricatorLiskDAO $object, PhabricatorLiskDAO $object,
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
$old = $xaction->getOldValue();
$new = $xaction->getNewValue();
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case PhabricatorTransactions::TYPE_EDGE: case PhabricatorTransactions::TYPE_EDGE:
$edge_type = $xaction->getMetadataValue('edge:type'); $edge_type = $xaction->getMetadataValue('edge:type');
switch ($edge_type) { switch ($edge_type) {
@ -220,7 +216,7 @@ final class PhabricatorProjectTransactionEditor
} }
break; break;
} }
return; break;
} }
return parent::applyBuiltinExternalTransaction($object, $xaction); return parent::applyBuiltinExternalTransaction($object, $xaction);