From 2189b6df6d8861e692679f137247a0937c7538a9 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 12 Jan 2015 07:20:20 -0800 Subject: [PATCH] Fix slowvote exception when viewing description diff Summary: Fixes T6937. We weren't passing required parameters. Test Plan: Followed repro steps in task. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6937 Differential Revision: https://secure.phabricator.com/D11346 --- resources/celerity/map.php | 4 ++-- .../slowvote/storage/PhabricatorSlowvoteTransaction.php | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 3dbc47b9fc..b523c91b90 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -78,7 +78,7 @@ return array( 'rsrc/css/application/objectselector/object-selector.css' => '029a133d', 'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b', 'rsrc/css/application/paste/paste.css' => 'aa1767d1', - 'rsrc/css/application/people/people-profile.css' => '0d5f6498', + 'rsrc/css/application/people/people-profile.css' => '25970776', 'rsrc/css/application/phame/phame.css' => '19ecc703', 'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee', 'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49', @@ -699,7 +699,7 @@ return array( 'owners-path-editor-css' => '2f00933b', 'paste-css' => 'aa1767d1', 'path-typeahead' => 'f7fc67ec', - 'people-profile-css' => '0d5f6498', + 'people-profile-css' => '25970776', 'phabricator-action-list-view-css' => '9ee9910a', 'phabricator-application-launch-view-css' => '5d71008f', 'phabricator-busy' => '6453c869', diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php b/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php index 2d73619957..abb73fd588 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php @@ -146,7 +146,10 @@ final class PhabricatorSlowvoteTransaction } public function renderChangeDetails(PhabricatorUser $viewer) { - return $this->renderTextCorpusChangeDetails($viewer); + return $this->renderTextCorpusChangeDetails( + $viewer, + $this->getOldValue(), + $this->getNewValue()); }