revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 00:10:57 +01:00
Code Issues Releases Wiki Activity

Fix spaces UI in PHUIHeaderView

Browse source 
Summary: This should consistenly apply the styling regardless of font or size of the Header. Fixes T10485

Test Plan: Visit a Task and a Countdown in a different Space.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T10485

Differential Revision: https://secure.phabricator.com/D15374
This commit is contained in:
Chad Little 2016-03-01 11:43:58 -08:00
parent fe7e288cf5
commit 21f8323612
3 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => 'e50c063a', 'core.pkg.css' => '3b2e293c',
'core.pkg.js' => '7d8faf57', 'core.pkg.js' => '7d8faf57',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9', 'differential.pkg.css' => '2de124c9',
@ -135,7 +135,7 @@ return array(
'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e', 'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e',
'rsrc/css/phui/phui-form.css' => 'aac1d51d', 'rsrc/css/phui/phui-form.css' => 'aac1d51d',
'rsrc/css/phui/phui-head-thing.css' => '11731da0', 'rsrc/css/phui/phui-head-thing.css' => '11731da0',
'rsrc/css/phui/phui-header-view.css' => 'b541cc78', 'rsrc/css/phui/phui-header-view.css' => '6152c91b',
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119', 'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad', 'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
'rsrc/css/phui/phui-icon.css' => '3f33ab57', 'rsrc/css/phui/phui-icon.css' => '3f33ab57',
@ -820,7 +820,7 @@ return array(
'phui-form-css' => 'aac1d51d', 'phui-form-css' => 'aac1d51d',
'phui-form-view-css' => '4a1a0f5e', 'phui-form-view-css' => '4a1a0f5e',
'phui-head-thing-view-css' => '11731da0', 'phui-head-thing-view-css' => '11731da0',
'phui-header-view-css' => 'b541cc78', 'phui-header-view-css' => '6152c91b',
'phui-hovercard' => '1bd28176', 'phui-hovercard' => '1bd28176',
'phui-hovercard-view-css' => 'de1a2119', 'phui-hovercard-view-css' => 'de1a2119',
'phui-icon-set-selector-css' => '1ab67aad', 'phui-icon-set-selector-css' => '1ab67aad',

8
src/view/phui/PHUIHeaderView.php
View file

@ -253,8 +253,9 @@ final class PHUIHeaderView extends AphrontTagView {
$left = array(); $left = array();
$right = array(); $right = array();
$space_header = null;
if ($viewer) { if ($viewer) {
$left[] = id(new PHUISpacesNamespaceContextView()) $space_header = id(new PHUISpacesNamespaceContextView())
->setUser($viewer) ->setUser($viewer)
->setObject($this->policyObject); ->setObject($this->policyObject);
} }
@ -335,7 +336,10 @@ final class PHUIHeaderView extends AphrontTagView {
array( array(
'class' => 'phui-header-header', 'class' => 'phui-header-header',
), ),
$header_content); array(
$space_header,
$header_content,
));
if ($this->subheader || $this->badges) { if ($this->subheader || $this->badges) {
$badges = null; $badges = null;

8
webroot/rsrc/css/phui/phui-header-view.css
View file

@ -272,10 +272,16 @@ body .phui-header-shell.phui-bleed-header
font-size: 18px; font-size: 18px;
} }
.spaces-name .phui-handle { .spaces-name .phui-handle,
.spaces-name a.phui-handle {
color: {$sh-redtext}; color: {$sh-redtext};
} }
.device-desktop .spaces-name a.phui-handle:hover {
color: {$sh-redtext};
text-decoration: underline;
}
.phui-header-subheader .phui-badge-flex-view { .phui-header-subheader .phui-badge-flex-view {
display: inline; display: inline;
margin-right: 4px; margin-right: 4px;