mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:348] ``` Closes T15658 Test Plan: Create an empty new Git repository, go to its URIs management page. Reviewers: O1 Blessed Committers, speck Reviewed By: O1 Blessed Committers, speck Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15658 Differential Revision: https://we.phorge.it/D25454
This commit is contained in:
parent
d4b110af26
commit
222a6fea0a
1 changed files with 2 additions and 2 deletions
|
@ -345,12 +345,12 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
|
|||
|
||||
// Make some reasonable effort to produce reasonable default directory
|
||||
// names from repository names.
|
||||
if (!strlen($name)) {
|
||||
if (!phutil_nonempty_string($name)) {
|
||||
$name = $this->getName();
|
||||
$name = phutil_utf8_strtolower($name);
|
||||
$name = preg_replace('@[ -/:->]+@', '-', $name);
|
||||
$name = trim($name, '-');
|
||||
if (!strlen($name)) {
|
||||
if (!phutil_nonempty_string($name)) {
|
||||
$name = $this->getCallsign();
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue