revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:348]
```

Closes T15658

Test Plan: Create an empty new Git repository, go to its URIs management page.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15658

Differential Revision: https://we.phorge.it/D25454
This commit is contained in:
Andre Klapper 2023-11-04 19:34:00 +01:00
parent d4b110af26
commit 222a6fea0a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/repository/storage/PhabricatorRepository.php
View file

@ -345,12 +345,12 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
// Make some reasonable effort to produce reasonable default directory // Make some reasonable effort to produce reasonable default directory
// names from repository names. // names from repository names.
if (!strlen($name)) { if (!phutil_nonempty_string($name)) {
$name = $this->getName(); $name = $this->getName();
$name = phutil_utf8_strtolower($name); $name = phutil_utf8_strtolower($name);
$name = preg_replace('@[ -/:->]+@', '-', $name); $name = preg_replace('@[ -/:->]+@', '-', $name);
$name = trim($name, '-'); $name = trim($name, '-');
if (!strlen($name)) { if (!phutil_nonempty_string($name)) {
$name = $this->getCallsign(); $name = $this->getCallsign();
} }
} }