From 22de31c56d6f6fd501eaa76fdd0cd8793bb497ab Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sat, 8 Aug 2015 11:17:10 -0700 Subject: [PATCH] Fix Ponder feed story transaction Summary: These transactions were missed, add in all closed states. Test Plan: Closed a Question, see title in Feed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D13831 --- .../ponder/storage/PonderQuestionTransaction.php | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/applications/ponder/storage/PonderQuestionTransaction.php b/src/applications/ponder/storage/PonderQuestionTransaction.php index 38f2b5e45b..80cb9f83f0 100644 --- a/src/applications/ponder/storage/PonderQuestionTransaction.php +++ b/src/applications/ponder/storage/PonderQuestionTransaction.php @@ -237,12 +237,22 @@ final class PonderQuestionTransaction switch ($new) { case PonderQuestionStatus::STATUS_OPEN: return pht( - '%s reopened %s', + '%s reopened %s.', $this->renderHandleLink($author_phid), $this->renderHandleLink($object_phid)); - case PonderQuestionStatus::STATUS_CLOSED: + case PonderQuestionStatus::STATUS_CLOSED_RESOLVED: return pht( - '%s closed %s', + '%s closed %s as resolved.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid)); + case PonderQuestionStatus::STATUS_CLOSED_DUPLICATE: + return pht( + '%s closed %s as duplicate.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid)); + case PonderQuestionStatus::STATUS_CLOSED_OBSOLETE: + return pht( + '%s closed %s as obsolete.', $this->renderHandleLink($author_phid), $this->renderHandleLink($object_phid)); }