mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Make the PhabricatorApplication::getName()
method abstract
Summary: In D10027, the `getName()` method was added to `PhabricatorApplication` to //allow// applications to explicitly declare their names rather than relying on the name being inferred from the name of the `PhabricatorApplication` subclass. I feel that sufficient time has passed such that we can //require// applications to explicitly declare their names. Test Plan: N/A Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11119
This commit is contained in:
parent
a896494ce5
commit
22ee37e8b5
1 changed files with 1 additions and 17 deletions
|
@ -28,23 +28,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
|
||||||
|
|
||||||
/* -( Application Information )-------------------------------------------- */
|
/* -( Application Information )-------------------------------------------- */
|
||||||
|
|
||||||
|
public abstract function getName();
|
||||||
/**
|
|
||||||
* TODO: This should be abstract, but is not for historical reasons.
|
|
||||||
*/
|
|
||||||
public function getName() {
|
|
||||||
phutil_deprecated(
|
|
||||||
'Automatic naming of `PhabricatorApplication` classes.',
|
|
||||||
'You should override the `getName` method.');
|
|
||||||
|
|
||||||
$match = null;
|
|
||||||
$regex = '/^PhabricatorApplication([A-Z][a-zA-Z]*)$/';
|
|
||||||
if (preg_match($regex, get_class($this), $match)) {
|
|
||||||
return $match[1];
|
|
||||||
}
|
|
||||||
|
|
||||||
throw new PhutilMethodNotImplementedException();
|
|
||||||
}
|
|
||||||
|
|
||||||
public function getShortDescription() {
|
public function getShortDescription() {
|
||||||
return $this->getName().' Application';
|
return $this->getName().' Application';
|
||||||
|
|
Loading…
Reference in a new issue