Swap Maniphest edit writes to new transactions

Summary: Ref T2217. This is essentially the last writer, should be able to start deleting code now.

Test Plan: Used "Edit Task" to make a bunch of task edits.

Reviewers: btrahan, garoevans

Reviewed By: garoevans

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7090

src/applications/maniphest/controller/ManiphestTaskEditController.php

@@ -210,9 +210,7 @@ final class ManiphestTaskEditController extends ManiphestController {
             'ip' => $request->getRemoteAddr(),
           ));
 
-        $template = new ManiphestTransaction();
-        $template->setAuthorPHID($user->getPHID());
-        $template->setContentSource($content_source);
+        $template = new ManiphestTransactionPro();
         $transactions = array();
 
         foreach ($changes as $type => $value) {
@@ -265,10 +263,11 @@ final class ManiphestTaskEditController extends ManiphestController {
           $task = $event->getValue('task');
           $transactions = $event->getValue('transactions');
 
-          $editor = new ManiphestTransactionEditor();
-          $editor->setActor($user);
-          $editor->setAuxiliaryFields($aux_fields);
-          $editor->applyTransactions($task, $transactions);
+          $editor = id(new ManiphestTransactionEditorPro())
+            ->setActor($user)
+            ->setContentSourceFromRequest($request)
+            ->setContinueOnNoEffect(true)
+            ->applyTransactions($task, $transactions);
 
           $event = new PhabricatorEvent(
             PhabricatorEventType::TYPE_MANIPHEST_DIDEDITTASK,

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -379,6 +379,7 @@ abstract class PhabricatorApplicationTransactionEditor
 
       $xaction->setAuthorPHID($actor->getPHID());
       $xaction->setContentSource($this->getContentSource());
+      $xaction->attachViewer($this->getActor());
     }
 
     $is_preview = $this->getIsPreview();