1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00

Give Phriction documents a normal timeline

Summary:
Ref T13077. See PHI840. Ref T1894. I'm planning to just let you comment on Phriction documents. I think this will create a few problems (e.g., around popular documents which collect long comment threads that are eventually obsolete) but nothing should be too terribly critical (e.g., we handle it gracefully when objects have very large number of comments/transactions) and for most documents this is likely just a net improvement.

"Just enable comments" is probably not the final iteration on this, but I think it's probably a step forward on the balance, not a step sideways or a slippery slope down into a dark hole or anything.

Test Plan: {F5877316}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13077, T1894

Differential Revision: https://secure.phabricator.com/D19659
This commit is contained in:
epriestley 2018-09-11 08:10:38 -07:00
parent 185e72c881
commit 2379c21fbb

View file

@ -348,6 +348,10 @@ final class PhrictionDocumentController
$page_content->setCurtain($curtain);
}
$timeline = $this->buildTransactionTimeline(
$document,
new PhrictionTransactionQuery());
return $this->newPage()
->setTitle($page_title)
->setCrumbs($crumbs)
@ -356,7 +360,15 @@ final class PhrictionDocumentController
array(
$page_content,
$prop_list,
$children,
phutil_tag(
'div',
array(
'class' => 'phui-document-view-pro-box',
),
array(
$children,
$timeline,
)),
));
}
@ -600,7 +612,7 @@ final class PhrictionDocumentController
),
$list)));
return phutil_tag_div('phui-document-view-pro-box', $box);
return $box;
}
private function renderChildDocumentLink(array $info) {