revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-18 17:58:37 +01:00
Code Issues Releases Wiki Activity

Add user icons / colors for subscriber transactions

Browse source 
Summary: Adds additional icon states for subscriber transactions. Also updated "eraser" to "trash" (man that icon is bad).

Test Plan: add a subscriber, remove a subscriber.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13800
This commit is contained in:
Chad Little 2015-08-05 12:40:47 -07:00
parent b34dc6164a
commit 2383e741aa
1 changed files with 29 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
View file

@ -362,11 +362,23 @@ abstract class PhabricatorApplicationTransaction
case PhabricatorTransactions::TYPE_COMMENT: case PhabricatorTransactions::TYPE_COMMENT:
$comment = $this->getComment(); $comment = $this->getComment();
if ($comment && $comment->getIsRemoved()) { if ($comment && $comment->getIsRemoved()) {
return 'fa-eraser'; return 'fa-trash';
} }
return 'fa-comment'; return 'fa-comment';
case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_SUBSCRIBERS:
return 'fa-envelope'; $old = $this->getOldValue();
$new = $this->getNewValue();
$add = array_diff($new, $old);
$rem = array_diff($old, $new);
if ($add && $rem) {
return 'fa-user';
} else if ($add) {
return 'fa-user-plus';
} else if ($rem) {
return 'fa-user-times';
} else {
return 'fa-user';
}
case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_VIEW_POLICY:
case PhabricatorTransactions::TYPE_EDIT_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY:
case PhabricatorTransactions::TYPE_JOIN_POLICY: case PhabricatorTransactions::TYPE_JOIN_POLICY:
@ -416,6 +428,21 @@ abstract class PhabricatorApplicationTransaction
return 'red'; return 'red';
} }
break; break;
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
$old = $this->getOldValue();
$new = $this->getNewValue();
$add = array_diff($new, $old);
$rem = array_diff($old, $new);
if ($add && $rem) {
return 'green';
} else if ($add) {
return 'green';
} else if ($rem) {
return 'black';
} else {
return null;
}
break;
} }
return null; return null;
} }