From 239eca13d753be4bdc513875f604c9dd24c8508e Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 12 Dec 2012 17:15:51 -0800 Subject: [PATCH] Fix fatal in Maniphest when viewing "show details" of a task description edit Summary: Clicking "show details" of a task description change in Maniphest currently throws an exception about the markup engine. Since we don't actually need the engine an alternate fix would be "if ($this->markupEngine) { $renderer->setMarkupEngine($this->markupEngine); }" but we have one at the ready so just provide it. This should become part of the Transactions stuff anyway. Test Plan: Clicked "show details". Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4167 --- .../maniphest/view/ManiphestTransactionDetailView.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/maniphest/view/ManiphestTransactionDetailView.php b/src/applications/maniphest/view/ManiphestTransactionDetailView.php index 8a8bd8749d..4c8fe1a836 100644 --- a/src/applications/maniphest/view/ManiphestTransactionDetailView.php +++ b/src/applications/maniphest/view/ManiphestTransactionDetailView.php @@ -575,6 +575,7 @@ final class ManiphestTransactionDetailView extends ManiphestView { $parser = new DifferentialChangesetParser(); $parser->setChangeset($changeset); $parser->setRenderingReference($id); + $parser->setMarkupEngine($this->markupEngine); $parser->setWhitespaceMode($whitespace_mode); $spec = $this->getRangeSpecification();