revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-26 11:10:16 +01:00
Code Issues Releases Wiki Activity

Hide the "large" diff warning on "very large" diffs

Browse source 
Summary:
Ref T13110. Ref T13130. When a revision is "large" (100 - 1000 files) we hide the actual textual changes by default. When it is "very large" (more than 1000 files) we hide all the changesets by default.

For "very large" diffs, we currently still show the "large" warning, which doesn't really make sense since there aren't any actual changesets.

When a diff is "very large", don't show the "large" warning.

Test Plan:
  - Viewed a small diff (<100 files), saw no warnings.
  - Viewed a large diff (100-1000 files), saw just the large warning.
  - Viewed a very large diff (>1000 files).
    - Before: both "large" and "very large" help warnings.
    - After: just "very large" warnings.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13130, T13110

Differential Revision: https://secure.phabricator.com/D19416
This commit is contained in:
epriestley 2018-04-30 11:51:55 -07:00
parent afc3099ee7
commit 24305cadb9
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -153,9 +153,17 @@ final class DifferentialRevisionViewController extends DifferentialController {
$request_uri = $request->getRequestURI();
// Revisions with more than 100 files are "large".
// Revisions with more than 1000 files are "very large".
$limit = 100;
$large = $request->getStr('large');
if (count($changesets) > $limit && !$large) {
$large_warning =
(!$this->isVeryLargeDiff()) &&
(count($changesets) > $limit) &&
(!$large);
if ($large_warning) {
$count = count($changesets);
$warning = new PHUIInfoView();
$warning->setTitle(pht('Large Diff'));