From 2432a479976cdb117c0de27b163752bdcf9972fa Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 9 Jul 2013 16:23:12 -0700 Subject: [PATCH] Reduce invasiveness of `bin/auth ldap` Summary: The once-choppy LDAP waters seem to have calmed down a bit. Use the service profile log to get a pretty good idea of what's going on with LDAP (see D6391) instead of invasive logging to get a slightly better idea. Test Plan: $ ~/src/php-src/sapi/cli/php -f ./bin/auth ldap --trace >>> [2] phabricator2_auth <<< [2] 1,755 us >>> [3] SELECT * FROM `auth_providerconfig` ORDER BY id DESC <<< [3] 423 us Enter LDAP Credentials LDAP Username: ldapuser >>> [4] $ stty -echo <<< [4] 10,370 us LDAP Password: >>> [5] $ stty echo <<< [5] 6,844 us Connecting to LDAP... >>> [6] connect (127.0.0.1:389) <<< [6] 12,932 us >>> [7] bind (sn=ldapuser,ou=People, dc=aphront, dc=com) <<< [7] 6,860 us >>> [8] search (ou=People, dc=aphront, dc=com, sn=ldapuser) <<< [8] 5,907 us Found LDAP Account: ldapuser Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6392 --- .../auth/management/PhabricatorAuthManagementLDAPWorkflow.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php index 559d4540be..795ceeba4a 100644 --- a/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php +++ b/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php @@ -31,10 +31,6 @@ final class PhabricatorAuthManagementLDAPWorkflow } $adapter = $provider->getAdapter(); - $adapter->setConsole($console); - - $console->writeOut("%s\n", pht('LDAP CONFIGURATION')); - $adapter->printConfiguration(); $console->writeOut("%s\n", pht('Enter LDAP Credentials')); $username = phutil_console_prompt("LDAP Username: ");