Calendar event edit view should validate that start time preceeds end time

Summary: Closes T8023, Calendar event edit view should validate that start time preceeds end time .

Test Plan: Create Calendar event, add details, make end time be earlier than start time, try to save, get error, make sure all previously entered details are populated correctly.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8023

Differential Revision: https://secure.phabricator.com/D12656

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

@@ -175,6 +175,34 @@ final class PhabricatorCalendarEventEditor
     return parent::applyCustomExternalTransaction($object, $xaction);
   }
 
+  protected function validateAllTransactions(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    $start_date_xaction = PhabricatorCalendarEventTransaction::TYPE_START_DATE;
+    $end_date_xaction = PhabricatorCalendarEventTransaction::TYPE_END_DATE;
+    $start_date = $object->getDateFrom();
+    $end_date = $object->getDateTo();
+    $errors = array();
+
+    foreach ($xactions as $xaction) {
+      if ($xaction->getTransactionType() == $start_date_xaction) {
+        $start_date = $xaction->getNewValue()->getEpoch();
+      } else if ($xaction->getTransactionType() == $end_date_xaction) {
+        $end_date = $xaction->getNewValue()->getEpoch();
+      }
+    }
+    if ($start_date > $end_date) {
+      $type = PhabricatorCalendarEventTransaction::TYPE_END_DATE;
+      $errors[] = new PhabricatorApplicationTransactionValidationError(
+        $type,
+        pht('Invalid'),
+        pht('End date must be after start date.'),
+        null);
+    }
+
+    return $errors;
+  }
+
   protected function validateTransaction(
     PhabricatorLiskDAO $object,
     $type,

src/applications/calendar/exception/PhabricatorCalendarEventInvalidEpochException.php

@@ -1,3 +0,0 @@
-<?php
-
-final class PhabricatorCalendarEventInvalidEpochException extends Exception {}

src/applications/calendar/storage/PhabricatorCalendarEvent.php

@@ -42,10 +42,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
   }
 
   public function save() {
-    if ($this->getDateTo() < $this->getDateFrom()) {
-      throw new PhabricatorCalendarEventInvalidEpochException();
-    }
-
     if (!$this->mailKey) {
       $this->mailKey = Filesystem::readRandomCharacters(20);
     }

src/applications/people/conduit/UserAddStatusConduitAPIMethod.php

@@ -50,17 +50,13 @@ final class UserAddStatusConduitAPIMethod extends UserConduitAPIMethod {
     $status      = $request->getValue('status');
     $description = $request->getValue('description', '');
 
-    try {
-      id(new PhabricatorCalendarEvent())
-        ->setUserPHID($user_phid)
-        ->setDateFrom($from)
-        ->setDateTo($to)
-        ->setTextStatus($status)
-        ->setDescription($description)
-        ->save();
-    } catch (PhabricatorCalendarEventInvalidEpochException $e) {
-      throw new ConduitException('ERR-BAD-EPOCH');
-    }
+    id(new PhabricatorCalendarEvent())
+      ->setUserPHID($user_phid)
+      ->setDateFrom($from)
+      ->setDateTo($to)
+      ->setTextStatus($status)
+      ->setDescription($description)
+      ->save();
   }
 
 }

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -639,6 +639,7 @@ abstract class PhabricatorApplicationTransactionEditor
         $errors[] = $this->validateTransaction($object, $type, $type_xactions);
       }
 
+      $errors[] = $this->validateAllTransactions($object, $xactions);
       $errors = array_mergev($errors);
 
       $continue_on_missing = $this->getContinueOnMissingFields();
@@ -1824,6 +1825,12 @@ abstract class PhabricatorApplicationTransactionEditor
     return clone $object;
   }
 
+  protected function validateAllTransactions(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return array();
+  }
+
   /**
    * Check for a missing text field.
    *