revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception which blocks rendering Phortune account page

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15363

Test Plan: Applied this change and "Default Account" page `/phortune/account/1/details/` rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15363

Differential Revision: https://we.phorge.it/D25201
This commit is contained in:
Andre Klapper 2023-05-08 14:35:55 +02:00
parent aa8baf1c8b
commit 25e93501c3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/phortune/xaction/PhortuneAccountNameTransaction.php
View file

@ -17,7 +17,7 @@ final class PhortuneAccountNameTransaction
$old = $this->getOldValue(); $old = $this->getOldValue();
$new = $this->getNewValue(); $new = $this->getNewValue();
if (strlen($old) && strlen($new)) { if (phutil_nonempty_string($old) && phutil_nonempty_string($new)) {
return pht( return pht(
'%s renamed this account from %s to %s.', '%s renamed this account from %s to %s.',
$this->renderAuthor(), $this->renderAuthor(),