mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Don't allow logged out users to initialize a Workboard
Summary: Right now logged out users can enable a workboard on a project. Test Plan: Log out, view a public project, click on Workboard, get not set up dialog. Click Cancel, return to project details. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14304
This commit is contained in:
parent
d784bf1ea8
commit
267e718dfe
1 changed files with 17 additions and 0 deletions
|
@ -67,6 +67,9 @@ final class PhabricatorProjectBoardViewController
|
||||||
// TODO: Expand the checks here if we add the ability
|
// TODO: Expand the checks here if we add the ability
|
||||||
// to hide the Backlog column
|
// to hide the Backlog column
|
||||||
if (!$columns) {
|
if (!$columns) {
|
||||||
|
if (!$viewer->isLoggedIn()) {
|
||||||
|
return $this->noAccessDialog($project);
|
||||||
|
}
|
||||||
switch ($request->getStr('initialize-type')) {
|
switch ($request->getStr('initialize-type')) {
|
||||||
case 'backlog-only':
|
case 'backlog-only':
|
||||||
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
|
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
|
||||||
|
@ -713,6 +716,20 @@ final class PhabricatorProjectBoardViewController
|
||||||
->setDialog($dialog);
|
->setDialog($dialog);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private function noAccessDialog(PhabricatorProject $project) {
|
||||||
|
|
||||||
|
$instructions = pht('This workboard has not been setup yet.');
|
||||||
|
|
||||||
|
$dialog = id(new AphrontDialogView())
|
||||||
|
->setUser($this->getRequest()->getUser())
|
||||||
|
->setTitle(pht('No Workboard'))
|
||||||
|
->addCancelButton($this->getApplicationURI('view/'.$project->getID().'/'))
|
||||||
|
->appendParagraph($instructions);
|
||||||
|
|
||||||
|
return id(new AphrontDialogResponse())
|
||||||
|
->setDialog($dialog);
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Add current state parameters (like order and the visibility of hidden
|
* Add current state parameters (like order and the visibility of hidden
|
||||||
|
|
Loading…
Reference in a new issue