From 2697dd53b6669eae08413bfc15f1c8b1eb30865a Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 14 Apr 2015 09:45:58 -0700 Subject: [PATCH] Use standard icon size, color on mobile headers Summary: This just matches the UI of icons on mobile with the icons size, color on desktop. Test Plan: test tablet and phone breakpoints. {F369688} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12407 --- resources/celerity/map.php | 6 +++--- src/view/page/menu/PhabricatorMainMenuView.php | 4 ++-- webroot/rsrc/css/application/base/main-menu-view.css | 8 +++++++- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index bd0d09fa62..df41e1771b 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '5ec98613', + 'core.pkg.css' => '7812d0b2', 'core.pkg.js' => '6a4f677f', 'darkconsole.pkg.js' => '8ab24e01', 'differential.pkg.css' => '3500921f', @@ -34,7 +34,7 @@ return array( 'rsrc/css/aphront/typeahead.css' => '0e403212', 'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af', 'rsrc/css/application/auth/auth.css' => '1e655982', - 'rsrc/css/application/base/main-menu-view.css' => 'af66f1d4', + 'rsrc/css/application/base/main-menu-view.css' => 'fd6382c0', 'rsrc/css/application/base/notification-menu.css' => '6aa0a74b', 'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f', 'rsrc/css/application/base/standard-page-view.css' => 'd2a6518d', @@ -731,7 +731,7 @@ return array( 'phabricator-hovercard-view-css' => '893f4783', 'phabricator-keyboard-shortcut' => '1ae869f2', 'phabricator-keyboard-shortcut-manager' => 'c1700f6f', - 'phabricator-main-menu-view' => 'af66f1d4', + 'phabricator-main-menu-view' => 'fd6382c0', 'phabricator-nav-view-css' => '7aeaf435', 'phabricator-notification' => '0c6946e7', 'phabricator-notification-css' => '9c279160', diff --git a/src/view/page/menu/PhabricatorMainMenuView.php b/src/view/page/menu/PhabricatorMainMenuView.php index 6f7e7a1382..a6309b89f7 100644 --- a/src/view/page/menu/PhabricatorMainMenuView.php +++ b/src/view/page/menu/PhabricatorMainMenuView.php @@ -152,7 +152,7 @@ final class PhabricatorMainMenuView extends AphrontView { 'span', array( 'class' => 'phabricator-menu-button-icon phui-icon-view '. - 'phui-font-fa fa-bars white', + 'phui-font-fa fa-bars', 'id' => $button_id, ), '')); @@ -215,7 +215,7 @@ final class PhabricatorMainMenuView extends AphrontView { 'span', array( 'class' => 'phabricator-menu-button-icon phui-icon-view '. - 'phui-font-fa fa-search white', + 'phui-font-fa fa-search', 'id' => $button_id, ), '')); diff --git a/webroot/rsrc/css/application/base/main-menu-view.css b/webroot/rsrc/css/application/base/main-menu-view.css index d8e1f69988..ad2830b702 100644 --- a/webroot/rsrc/css/application/base/main-menu-view.css +++ b/webroot/rsrc/css/application/base/main-menu-view.css @@ -81,7 +81,13 @@ } .phabricator-menu-button-icon.phui-icon-view { - font-size: 24px; + font-size: 20px; + height: 20px; + width: 20px; + color: rgba(255,255,255,.8); + text-align: center; + vertical-align: middle; + line-height: 24px; } .phabricator-expand-application-menu,