mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 14:52:41 +01:00
Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15382 Test Plan: Applied this change and after performing steps to send a test message again, `/mail/detail/107/` page got rendered correctly and I can see the "Status Details" with stuff like "//None//" or "No mailers are configured." Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15382 Differential Revision: https://we.phorge.it/D25215
This commit is contained in:
parent
8a1cfff1e8
commit
26aed4935b
1 changed files with 1 additions and 1 deletions
|
@ -421,7 +421,7 @@ final class PhabricatorMetaMTAMailViewController
|
|||
$properties->addProperty(pht('Message PHID'), $mail->getPHID());
|
||||
|
||||
$details = $mail->getMessage();
|
||||
if (!strlen($details)) {
|
||||
if (!phutil_nonempty_string($details)) {
|
||||
$details = phutil_tag('em', array(), pht('None'));
|
||||
}
|
||||
$properties->addProperty(pht('Status Details'), $details);
|
||||
|
|
Loading…
Reference in a new issue