revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

phd - on start command accurately detect if daemons are running before erroring out

Browse source 
Summary: loadRunningDaemons loads daemons that may be running (have a file pid). other commands handle this appropriately so just make sure the start command knows whats up

Test Plan: phd start, stop, reload all seemed to work just fine.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1284

Differential Revision: https://secure.phabricator.com/D2808
This commit is contained in:
Bob Trahan 2012-06-20 12:36:31 -07:00
parent a4e2eb3d8c
commit 26ca5cbbe3
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
scripts/daemon/phabricator_daemon_launcher.php
View file

@ -56,7 +56,11 @@ switch ($command) {
/* Fall Through */ /* Fall Through */
case 'start': case 'start':
$running = $control->loadRunningDaemons(); $running = $control->loadRunningDaemons();
if ($running) { // "running" might not mean actually running so much as was running at
// some point. ergo, do a quick grouping and only barf if daemons are
// *actually* running.
$running_dict = mgroup($running, 'isRunning');
if (!empty($running_dict[true])) {
echo phutil_console_wrap( echo phutil_console_wrap(
"phd start: Unable to start daemons because daemons are already ". "phd start: Unable to start daemons because daemons are already ".
"running.\n". "running.\n".