revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception which blocks deleting Phriction document

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15419

Test Plan:
Applied this changes and page at `/w/` correctly rendered saying `Document Deleted - This document has been deleted. You can edit it to put new content here, or use history to revert to an earlier version.`

Also test creating it again, and updating it again: it still works.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15419

Differential Revision: https://we.phorge.it/D25243
This commit is contained in:
Andre Klapper 2023-05-24 18:08:40 +02:00
parent b1edfea09b
commit 26d74ccc7c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/phriction/editor/PhrictionTransactionEditor.php
View file

@ -556,7 +556,7 @@ final class PhrictionTransactionEditor
->setContent($this->getOldContent()->getContent()) ->setContent($this->getOldContent()->getContent())
->setDescription(''); ->setDescription('');
if (strlen($this->getDescription())) { if (phutil_nonempty_string($this->getDescription())) {
$content->setDescription($this->getDescription()); $content->setDescription($this->getDescription());
} }