revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-06 01:18:25 +02:00
Code Issues Releases Wiki Activity

Restrict Audit buckets to just ApplicationSearch views

Browse source 
Summary: Fixes T9363. This drops empty buckets from dashboard panel context. Still see full results in Audit.

Test Plan: Create an "Active Audits" panel, add to Dashboard. See no commits found. Check Audit, see all buckets.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9363

Differential Revision: https://secure.phabricator.com/D17545
This commit is contained in:
Chad Little 2017-03-23 12:46:11 -07:00
parent 4f2bca58fc
commit 2707681b48
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/applications/audit/query/PhabricatorCommitSearchEngine.php
View file

@ -178,10 +178,13 @@ final class PhabricatorCommitSearchEngine
$groups = $bucket->newResultGroups($query, $commits); $groups = $bucket->newResultGroups($query, $commits);
foreach ($groups as $group) { foreach ($groups as $group) {
$views[] = id(clone $template) // Don't show groups in Dashboard Panels
->setHeader($group->getName()) if ($group->getObjects() || !$this->isPanelContext()) {
->setNoDataString($group->getNoDataString()) $views[] = id(clone $template)
->setCommits($group->getObjects()); ->setHeader($group->getName())
->setNoDataString($group->getNoDataString())
->setCommits($group->getObjects());
}
} }
} catch (Exception $ex) { } catch (Exception $ex) {
$this->addError($ex->getMessage()); $this->addError($ex->getMessage());
@ -189,7 +192,13 @@ final class PhabricatorCommitSearchEngine
} else { } else {
$views[] = id(clone $template) $views[] = id(clone $template)
->setCommits($commits) ->setCommits($commits)
->setNoDataString(pht('No matching commits.')); ->setNoDataString(pht('No commits found.'));
}
if (!$views) {
$views[] = id(new PhabricatorAuditListView())
->setViewer($viewer)
->setNoDataString(pht('No commits found.'));
} }
if (count($views) == 1) { if (count($views) == 1) {