From 271e104c7ea42c625730100793d7ec5593e90919 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 6 Apr 2020 11:19:39 -0700 Subject: [PATCH] Update DivinerAtomController for a long-ago change to the docblock parser API Summary: Ref T13505. See that task for discussion. Test Plan: Ran `diviner generate` locally, found a page fataling on this `strlen()`, applied patch, got a sketchy but not-broken page. Maniphest Tasks: T13505 Differential Revision: https://secure.phabricator.com/D21061 --- src/applications/diviner/controller/DivinerAtomController.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/applications/diviner/controller/DivinerAtomController.php b/src/applications/diviner/controller/DivinerAtomController.php index 0c92bd1738..3363f55c8e 100644 --- a/src/applications/diviner/controller/DivinerAtomController.php +++ b/src/applications/diviner/controller/DivinerAtomController.php @@ -435,9 +435,7 @@ final class DivinerAtomController extends DivinerController { $task_specs = array(); $tasks = $symbol->getAtom()->getDocblockMetaValue('task'); - if (strlen($tasks)) { - $tasks = phutil_split_lines($tasks, $retain_endings = false); - + if ($tasks) { foreach ($tasks as $task) { list($name, $title) = explode(' ', $task, 2); $name = trim($name);