revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
Code Issues Releases Wiki Activity

Burnup report showing decimals on hover

Browse source 
Summary:
Added yformat to ManiphestReportController.  Removed [yy] from the js.
Will pull config.yformat or send []. The old way with [yy] never seemed to worked having config.yformat, also would crash if yformat was in with value

Test Plan: Loadup burn up report, hover over a given date. Number of tasks opened should be an int

Reviewers: epriestley, #blessed_reviewers

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8080
This commit is contained in:
Guy Warner 2014-01-27 13:48:23 -08:00 committed by epriestley
parent 8735ec4dbe
commit 2721aa272b
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/maniphest/controller/ManiphestReportController.php
View file

@ -294,6 +294,7 @@ final class ManiphestReportController extends ManiphestController {
$burn_y, $burn_y,
), ),
'xformat' => 'epoch', 'xformat' => 'epoch',
'yformat' => 'int',
)); ));
return array($filter, $chart, $panel); return array($filter, $chart, $panel);

2
webroot/rsrc/js/application/maniphest/behavior-line-chart.js
View file

@ -64,7 +64,7 @@ JX.behavior('line-chart', function(config) {
if (config.x[0][ii] > this.axis) { if (config.x[0][ii] > this.axis) {
break; break;
} }
yvalue = format(config.y[yy][ii], (config.yformat || [])[yy]); yvalue = format(config.y[yy][ii], config.yformat);
} }
var xvalue = format(this.axis, config.xformat); var xvalue = format(this.axis, config.xformat);