revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-31 00:48:21 +01:00
Code Issues Releases Wiki Activity

Fix appearance of "Differential Revision" on edit interfaces

Browse source 
Summary: The recent change to the field causes us to render "http://junk.com/D"
in some cases, just null the field if there's no data.

Test Plan: Ran "arc diff --create".

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Differential Revision: https://secure.phabricator.com/D1321
This commit is contained in:
epriestley 2012-01-05 11:37:03 -08:00
parent 1cb81936e7
commit 275472d70f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/differential/field/specification/revisionid/DifferentialRevisionIDFieldSpecification.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -47,6 +47,9 @@ final class DifferentialRevisionIDFieldSpecification
} }
public function renderValueForCommitMessage($is_edit) { public function renderValueForCommitMessage($is_edit) {
if ($is_edit || !$this->id) {
return null;
}
return PhabricatorEnv::getProductionURI('/D'.$this->id); return PhabricatorEnv::getProductionURI('/D'.$this->id);
} }