revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Don't delete tasks attached by freeform fields in Maniphest Tasks field

Browse source 
Summary: I didn't catch this issue at D3986 because we don't have `DifferentialManiphestTasksFieldSpecification` in field selector.

Test Plan:
Added `DifferentialManiphestTasksFieldSpecification` too field selector.
Wrote `Refs T4` and not filled `T4` to Maniphest Tasks field.

Reviewers: epriestley, 20after4

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T945

Differential Revision: https://secure.phabricator.com/D4073
This commit is contained in:
vrana 2012-12-03 16:19:17 -08:00
parent bff795d848
commit 27785c4f75
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php
View file

@ -3,6 +3,7 @@
final class DifferentialManiphestTasksFieldSpecification final class DifferentialManiphestTasksFieldSpecification
extends DifferentialFieldSpecification { extends DifferentialFieldSpecification {
private $oldManiphestTasks = array();
private $maniphestTasks = array(); private $maniphestTasks = array();
public function shouldAppearOnRevisionView() { public function shouldAppearOnRevisionView() {
@ -51,9 +52,7 @@ final class DifferentialManiphestTasksFieldSpecification
$revision_phid = $revision->getPHID(); $revision_phid = $revision->getPHID();
$edge_type = PhabricatorEdgeConfig::TYPE_DREV_HAS_RELATED_TASK; $edge_type = PhabricatorEdgeConfig::TYPE_DREV_HAS_RELATED_TASK;
$old_phids = PhabricatorEdgeQuery::loadDestinationPHIDs( $old_phids = $this->oldManiphestTasks;
$revision_phid,
$edge_type);
$add_phids = $this->maniphestTasks; $add_phids = $this->maniphestTasks;
$rem_phids = array_diff($old_phids, $add_phids); $rem_phids = array_diff($old_phids, $add_phids);
@ -73,6 +72,7 @@ final class DifferentialManiphestTasksFieldSpecification
protected function didSetRevision() { protected function didSetRevision() {
$this->maniphestTasks = $this->getManiphestTaskPHIDs(); $this->maniphestTasks = $this->getManiphestTaskPHIDs();
$this->oldManiphestTasks = $this->maniphestTasks;
} }
public function getRequiredHandlePHIDsForCommitMessage() { public function getRequiredHandlePHIDsForCommitMessage() {