revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Put the keyboard focus reticle back on top of diffs

Browse source 
Summary:
Fixes T10954. This got hidden underneath things at some point.

Use `pointer-events: none` to make the mouse ignore the element so that hover/select/edit/click still work "through" the element.

Design could probably be improved here, maybe I'll make it more-visible when you press {key n} and then have it fade quickly so it kind of gets out of your way once you find the block you want to read.

Test Plan: {F4921746}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10954

Differential Revision: https://secure.phabricator.com/D17784
This commit is contained in:
epriestley 2017-04-24 03:18:57 -07:00
parent b3c8226cbb
commit 27bdc322fc
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
webroot/rsrc/css/application/base/standard-page-view.css
View file

@ -61,9 +61,10 @@ body.white-background {
} }
.keyboard-focus-focus-reticle { .keyboard-focus-focus-reticle {
background: #ffffd3; background: rgba(255, 255, 211, 0.15);
position: absolute; position: absolute;
border: 1px solid #999900; border: 1px solid {$yellow};
pointer-events: none;
} }
a.handle-status-closed { a.handle-status-closed {

8
webroot/rsrc/css/core/z-index.css
View file

@ -2,16 +2,16 @@
* @provides phabricator-zindex-css * @provides phabricator-zindex-css
*/ */
.keyboard-focus-focus-reticle {
z-index: 1;
}
.device .phabricator-action-list-view.phabricator-action-list-toggle, .device .phabricator-action-list-view.phabricator-action-list-toggle,
.device-desktop .phui-document-content .device-desktop .phui-document-content
.phabricator-action-list-view.phabricator-action-list-toggle { .phabricator-action-list-view.phabricator-action-list-toggle {
z-index: 1; z-index: 1;
} }
.keyboard-focus-focus-reticle {
z-index: 2;
}
.device-desktop .phui-timeline-minor-event .phui-timeline-image { .device-desktop .phui-timeline-minor-event .phui-timeline-image {
z-index: 2; z-index: 2;
} }