Allow Conduit console to be browsed by logged-out users

Summary:
Ref T4830. A few methods, like `conduit.ping`, are callable without authentication, so this even has some use cases. Also:

  - Make some Differential stuff a little more consistent.
  - Use slightly more modern rendering.
  - Deprecate the status-oriented `user` calls; these will be replaced by Calendar methods.

Test Plan: Browsed console as logged out / logged in users.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4830

Differential Revision: https://secure.phabricator.com/D8826

src/__phutil_library_map__.php

@@ -2718,26 +2718,26 @@ phutil_register_library_map(array(
     'ConduitAPI_conpherence_updatethread_Method' => 'ConduitAPI_conpherence_Method',
     'ConduitAPI_differential_Method' => 'ConduitAPIMethod',
     'ConduitAPI_differential_close_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_createcomment_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_createcomment_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_creatediff_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_creatediff_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_createinline_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_createrawdiff_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_createrevision_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_find_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_find_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_finishpostponedlinters_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_finishpostponedlinters_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_getalldiffs_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_getalldiffs_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_getcommitmessage_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_getcommitmessage_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_getcommitpaths_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_getcommitpaths_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_getdiff_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_getdiff_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_getrawdiff_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_getrawdiff_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_getrevision_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_getrevisioncomments_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_parsecommitmessage_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_parsecommitmessage_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_query_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_querydiffs_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_querydiffs_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_setdiffproperty_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_setdiffproperty_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_differential_updaterevision_Method' => 'ConduitAPI_differential_Method',
-    'ConduitAPI_differential_updateunitresults_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_updateunitresults_Method' => 'ConduitAPI_differential_Method',
     'ConduitAPI_diffusion_Method' => 'ConduitAPIMethod',
     'ConduitAPI_diffusion_abstractquery_Method' => 'ConduitAPI_diffusion_Method',
     'ConduitAPI_diffusion_branchquery_Method' => 'ConduitAPI_diffusion_abstractquery_Method',

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

@@ -1,13 +1,14 @@
 <?php
 
-/**
- * @group conduit
- */
 final class PhabricatorConduitConsoleController
   extends PhabricatorConduitController {
 
   private $method;
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function willProcessRequest(array $data) {
     $this->method = $data['method'];
   }
@@ -26,28 +27,25 @@ final class PhabricatorConduitConsoleController
       return new Aphront404Response();
     }
 
+    $can_call_method = false;
+
     $status = $method->getMethodStatus();
     $reason = $method->getMethodStatusDescription();
+    $errors = array();
 
-    $status_view = null;
+    switch ($status) {
-    if ($status != ConduitAPIMethod::METHOD_STATUS_STABLE) {
+      case ConduitAPIMethod::METHOD_STATUS_DEPRECATED:
-      $status_view = new AphrontErrorView();
+        $reason = nonempty($reason, pht('This method is deprecated.'));
-      switch ($status) {
+        $errors[] = pht('Deprecated Method: %s', $reason);
-        case ConduitAPIMethod::METHOD_STATUS_DEPRECATED:
+        break;
-          $status_view->setTitle('Deprecated Method');
+      case ConduitAPIMethod::METHOD_STATUS_UNSTABLE:
-          $status_view->appendChild(
+        $reason = nonempty(
-            nonempty($reason, "This method is deprecated."));
+          $reason,
-          break;
+          pht(
-        case ConduitAPIMethod::METHOD_STATUS_UNSTABLE:
+            'This method is new and unstable. Its interface is subject '.
-          $status_view->setSeverity(AphrontErrorView::SEVERITY_WARNING);
+            'to change.'));
-          $status_view->setTitle('Unstable Method');
+        $errors[] = pht('Unstable Method: %s', $reason);
-          $status_view->appendChild(
+        break;
-            nonempty(
-              $reason,
-              "This method is new and unstable. Its interface is subject ".
-              "to change."));
-          break;
-      }
     }
 
     $error_types = $method->defineErrorTypes();
@@ -61,7 +59,8 @@ final class PhabricatorConduitConsoleController
       }
       $error_description = phutil_tag('ul', array(), $error_description);
     } else {
-      $error_description = "This method does not raise any specific errors.";
+      $error_description = pht(
+        'This method does not raise any specific errors.');
     }
 
     $form = new AphrontFormView();
@@ -95,29 +94,38 @@ final class PhabricatorConduitConsoleController
           ->setCaption($desc));
     }
 
-    $form
+    $must_login = !$viewer->isLoggedIn() &&
-      ->appendChild(
+                  $method->shouldRequireAuthentication();
-        id(new AphrontFormSelectControl())
+    if ($must_login) {
-          ->setLabel('Output Format')
+      $errors[] = pht(
-          ->setName('output')
+        'Login Required: This method requires authentication. You must '.
-          ->setOptions(
+        'log in before you can make calls to it.');
-            array(
+    } else {
-              'human' => 'Human Readable',
+      $form
-              'json'  => 'JSON',
+        ->appendChild(
-            )))
+          id(new AphrontFormSelectControl())
-      ->appendChild(
+            ->setLabel('Output Format')
-        id(new AphrontFormSubmitControl())
+            ->setName('output')
-          ->addCancelButton($this->getApplicationURI())
+            ->setOptions(
-          ->setValue('Call Method'));
+              array(
+                'human' => 'Human Readable',
+                'json'  => 'JSON',
+              )))
+        ->appendChild(
+          id(new AphrontFormSubmitControl())
+            ->addCancelButton($this->getApplicationURI())
+            ->setValue(pht('Call Method')));
+    }
+
+    $header = id(new PHUIHeaderView())
+      ->setUser($viewer)
+      ->setHeader($method->getAPIMethodName());
 
     $form_box = id(new PHUIObjectBoxView())
-      ->setHeaderText($method->getAPIMethodName())
+      ->setHeader($header)
+      ->setFormErrors($errors)
       ->setForm($form);
 
-    if ($status_view) {
-      $form_box->setErrorView($status_view);
-    }
-
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb($method->getAPIMethodName());
 

src/applications/conduit/controller/PhabricatorConduitListController.php

@@ -1,14 +1,15 @@
 <?php
 
-/**
- * @group conduit
- */
 final class PhabricatorConduitListController
   extends PhabricatorConduitController
   implements PhabricatorApplicationSearchResultsControllerInterface {
 
   private $queryKey;
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function willProcessRequest(array $data) {
     $this->queryKey = idx($data, 'queryKey');
   }

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_createcomment_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return pht("Add a comment to a Differential revision.");

src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php

@@ -1,6 +1,7 @@
 <?php
 
-final class ConduitAPI_differential_creatediff_Method extends ConduitAPIMethod {
+final class ConduitAPI_differential_creatediff_Method
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return "Create a new Differential diff.";

src/applications/differential/conduit/ConduitAPI_differential_createinline_Method.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_createinline_Method
   extends ConduitAPI_differential_Method {
 

src/applications/differential/conduit/ConduitAPI_differential_createrawdiff_Method.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_createrawdiff_Method
   extends ConduitAPI_differential_Method {
 

src/applications/differential/conduit/ConduitAPI_differential_find_Method.php

@@ -1,9 +1,7 @@
 <?php
 
-/**
+final class ConduitAPI_differential_find_Method
- * @group conduit
+  extends ConduitAPI_differential_Method {
- */
-final class ConduitAPI_differential_find_Method extends ConduitAPIMethod {
 
   public function getMethodStatus() {
     return self::METHOD_STATUS_DEPRECATED;

src/applications/differential/conduit/ConduitAPI_differential_finishpostponedlinters_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_finishpostponedlinters_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return "Update diff with new lint messages and mark postponed ".

src/applications/differential/conduit/ConduitAPI_differential_getalldiffs_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_getalldiffs_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodStatus() {
     return self::METHOD_STATUS_DEPRECATED;

src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php

@@ -1,7 +1,7 @@
 <?php
 
 final class ConduitAPI_differential_getcommitmessage_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return "Retrieve Differential commit messages or message templates.";

src/applications/differential/conduit/ConduitAPI_differential_getcommitpaths_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_getcommitpaths_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return "Query which paths should be included when committing a ".

src/applications/differential/conduit/ConduitAPI_differential_getdiff_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_getdiff_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function shouldAllowPublic() {
     return true;

src/applications/differential/conduit/ConduitAPI_differential_getrawdiff_Method.php

@@ -1,7 +1,7 @@
 <?php
 
 final class ConduitAPI_differential_getrawdiff_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return pht("Retrieve a raw diff");

src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php

@@ -1,7 +1,7 @@
 <?php
 
 final class ConduitAPI_differential_parsecommitmessage_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   private $errors;
 

src/applications/differential/conduit/ConduitAPI_differential_querydiffs_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_querydiffs_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return pht('Query differential diffs which match certain criteria.');

src/applications/differential/conduit/ConduitAPI_differential_setdiffproperty_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_setdiffproperty_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return "Attach properties to Differential diffs.";

src/applications/differential/conduit/ConduitAPI_differential_updateunitresults_Method.php

@@ -1,10 +1,7 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_updateunitresults_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
     return "Update arc unit results for a postponed test.";

src/applications/people/conduit/ConduitAPI_user_Method.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group conduit
- */
 abstract class ConduitAPI_user_Method extends ConduitAPIMethod {
 
   public function getApplication() {

src/applications/people/conduit/ConduitAPI_user_addstatus_Method.php

@@ -1,16 +1,20 @@
 <?php
 
-/**
+final class ConduitAPI_user_addstatus_Method
- * @group conduit
+  extends ConduitAPI_user_Method {
- */
-final class ConduitAPI_user_addstatus_Method extends ConduitAPI_user_Method {
 
   public function getMethodStatus() {
-    return self::METHOD_STATUS_UNSTABLE;
+    return self::METHOD_STATUS_DEPRECATED;
   }
 
   public function getMethodDescription() {
-    return "Add status information to the logged-in user.";
+    return pht("Add status information to the logged-in user.");
+  }
+
+  public function getMethodStatusDescription() {
+    return pht(
+      'Statuses are becoming full-fledged events as part of the '.
+      'Calendar application.');
   }
 
   public function defineParamTypes() {

src/applications/people/conduit/ConduitAPI_user_removestatus_Method.php

@@ -1,16 +1,19 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_user_removestatus_Method extends ConduitAPI_user_Method {
 
   public function getMethodStatus() {
-    return self::METHOD_STATUS_UNSTABLE;
+    return self::METHOD_STATUS_DEPRECATED;
   }
 
   public function getMethodDescription() {
-    return "Delete status information of the logged-in user.";
+    return pht("Delete status information of the logged-in user.");
+  }
+
+  public function getMethodStatusDescription() {
+    return pht(
+      'Statuses are becoming full-fledged events as part of the '.
+      'Calendar application.');
   }
 
   public function defineParamTypes() {