revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-02 02:40:58 +01:00
Code Issues Releases Wiki Activity

Make differential revision list less ambiguous.

Browse source 
Summary:

Test Plan:

Reviewers:

CC:
This commit is contained in:
epriestley 2011-02-22 23:37:43 -08:00
parent d0ea1f1c7b
commit 27dc5eabd7
1 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
View file

@ -27,6 +27,7 @@ class DifferentialRevisionListController extends DifferentialController {
public function processRequest() { public function processRequest() {
$filters = array( $filters = array(
'Your Revisions',
'active' => array( 'active' => array(
'name' => 'Active Revisions', 'name' => 'Active Revisions',
'queries' => array( 'queries' => array(
@ -49,7 +50,7 @@ class DifferentialRevisionListController extends DifferentialController {
'queries' => array( 'queries' => array(
array( array(
'query' => DifferentialRevisionListData::QUERY_OPEN_OWNED, 'query' => DifferentialRevisionListData::QUERY_OPEN_OWNED,
'header' => 'Open Revisions', 'header' => 'Your Open Revisions',
), ),
), ),
), ),
@ -58,7 +59,7 @@ class DifferentialRevisionListController extends DifferentialController {
'queries' => array( 'queries' => array(
array( array(
'query' => DifferentialRevisionListData::QUERY_OPEN_REVIEWER, 'query' => DifferentialRevisionListData::QUERY_OPEN_REVIEWER,
'header' => 'Open Reviews', 'header' => 'Your Open Reviews',
), ),
), ),
), ),
@ -67,7 +68,7 @@ class DifferentialRevisionListController extends DifferentialController {
'queries' => array( 'queries' => array(
array( array(
'query' => DifferentialRevisionListData::QUERY_OWNED, 'query' => DifferentialRevisionListData::QUERY_OWNED,
'header' => 'All Revisions', 'header' => 'Your Revisions',
), ),
), ),
), ),
@ -76,7 +77,18 @@ class DifferentialRevisionListController extends DifferentialController {
'queries' => array( 'queries' => array(
array( array(
'query' => DifferentialRevisionListData::QUERY_OWNED_OR_REVIEWER, 'query' => DifferentialRevisionListData::QUERY_OWNED_OR_REVIEWER,
'header' => 'All Revisions and Reviews', 'header' => 'Your Revisions and Reviews',
),
),
),
'<hr />',
'All Revisions',
'allopen' => array(
'name' => 'Open',
'queries' => array(
array(
'query' => DifferentialRevisionListData::QUERY_ALL_OPEN,
'header' => 'All Open Revisions',
), ),
), ),
), ),
@ -101,7 +113,17 @@ class DifferentialRevisionListController extends DifferentialController {
} }
$side_nav = new AphrontSideNavView(); $side_nav = new AphrontSideNavView();
foreach ($filters as $filter_name => $filter_desc) { foreach ($filters as $filter_name => $filter_desc) {
if (is_int($filter_name)) {
$side_nav->addNavItem(
phutil_render_tag(
'span',
array(),
$filter_desc));
continue;
}
$selected = ($filter_name == $this->filter); $selected = ($filter_name == $this->filter);
$side_nav->addNavItem( $side_nav->addNavItem(
phutil_render_tag( phutil_render_tag(