mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 12:00:55 +01:00
Use some more human-readable Conduit keys in updated API methods
Summary: Ref T12074. This uses more consistent Conduit keys for constraint names. This is a minor compatibility break on watchers/members but since these methods are more useful now this is probably a good time to try to get away with it, and a more consistent API is better in the long run. I need to issue compatibility guidance for the milestones thing anyway and that one isn't avoidable, so try to rip the bandage off all in one go. Test Plan: Reviewed new constraint names from console, called methods using them. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12074 Differential Revision: https://secure.phabricator.com/D17161
This commit is contained in:
parent
b08c9b3ffa
commit
27ecedd1d5
2 changed files with 5 additions and 0 deletions
|
@ -20,6 +20,7 @@ final class PhabricatorProjectColumnSearchEngine
|
|||
id(new PhabricatorPHIDsSearchField())
|
||||
->setLabel(pht('Projects'))
|
||||
->setKey('projectPHIDs')
|
||||
->setConduitKey('projects')
|
||||
->setAliases(array('project', 'projects', 'projectPHID')),
|
||||
);
|
||||
}
|
||||
|
|
|
@ -24,10 +24,12 @@ final class PhabricatorProjectSearchEngine
|
|||
id(new PhabricatorUsersSearchField())
|
||||
->setLabel(pht('Members'))
|
||||
->setKey('memberPHIDs')
|
||||
->setConduitKey('members')
|
||||
->setAliases(array('member', 'members')),
|
||||
id(new PhabricatorUsersSearchField())
|
||||
->setLabel(pht('Watchers'))
|
||||
->setKey('watcherPHIDs')
|
||||
->setConduitKey('watchers')
|
||||
->setAliases(array('watcher', 'watchers')),
|
||||
id(new PhabricatorSearchSelectField())
|
||||
->setLabel(pht('Status'))
|
||||
|
@ -55,11 +57,13 @@ final class PhabricatorProjectSearchEngine
|
|||
id(new PhabricatorPHIDsSearchField())
|
||||
->setLabel(pht('Parent Projects'))
|
||||
->setKey('parentPHIDs')
|
||||
->setConduitKey('parents')
|
||||
->setAliases(array('parent', 'parents', 'parentPHID'))
|
||||
->setDescription(pht('Find direct subprojects of specified parents.')),
|
||||
id(new PhabricatorPHIDsSearchField())
|
||||
->setLabel(pht('Ancestor Projects'))
|
||||
->setKey('ancestorPHIDs')
|
||||
->setConduitKey('ancestors')
|
||||
->setAliases(array('ancestor', 'ancestors', 'ancestorPHID'))
|
||||
->setDescription(
|
||||
pht('Find all subprojects beneath specified ancestors.')),
|
||||
|
|
Loading…
Reference in a new issue