revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Use some more human-readable Conduit keys in updated API methods

Browse source 
Summary:
Ref T12074. This uses more consistent Conduit keys for constraint names.

This is a minor compatibility break on watchers/members but since these methods are more useful now this is probably a good time to try to get away with it, and a more consistent API is better in the long run. I need to issue compatibility guidance for the milestones thing anyway and that one isn't avoidable, so try to rip the bandage off all in one go.

Test Plan: Reviewed new constraint names from console, called methods using them.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12074

Differential Revision: https://secure.phabricator.com/D17161
This commit is contained in:
epriestley 2017-01-09 07:35:54 -08:00
parent b08c9b3ffa
commit 27ecedd1d5
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/project/query/PhabricatorProjectColumnSearchEngine.php
View file

@ -20,6 +20,7 @@ final class PhabricatorProjectColumnSearchEngine
id(new PhabricatorPHIDsSearchField()) id(new PhabricatorPHIDsSearchField())
->setLabel(pht('Projects')) ->setLabel(pht('Projects'))
->setKey('projectPHIDs') ->setKey('projectPHIDs')
->setConduitKey('projects')
->setAliases(array('project', 'projects', 'projectPHID')), ->setAliases(array('project', 'projects', 'projectPHID')),
); );
} }

4
src/applications/project/query/PhabricatorProjectSearchEngine.php
View file

@ -24,10 +24,12 @@ final class PhabricatorProjectSearchEngine
id(new PhabricatorUsersSearchField()) id(new PhabricatorUsersSearchField())
->setLabel(pht('Members')) ->setLabel(pht('Members'))
->setKey('memberPHIDs') ->setKey('memberPHIDs')
->setConduitKey('members')
->setAliases(array('member', 'members')), ->setAliases(array('member', 'members')),
id(new PhabricatorUsersSearchField()) id(new PhabricatorUsersSearchField())
->setLabel(pht('Watchers')) ->setLabel(pht('Watchers'))
->setKey('watcherPHIDs') ->setKey('watcherPHIDs')
->setConduitKey('watchers')
->setAliases(array('watcher', 'watchers')), ->setAliases(array('watcher', 'watchers')),
id(new PhabricatorSearchSelectField()) id(new PhabricatorSearchSelectField())
->setLabel(pht('Status')) ->setLabel(pht('Status'))
@ -55,11 +57,13 @@ final class PhabricatorProjectSearchEngine
id(new PhabricatorPHIDsSearchField()) id(new PhabricatorPHIDsSearchField())
->setLabel(pht('Parent Projects')) ->setLabel(pht('Parent Projects'))
->setKey('parentPHIDs') ->setKey('parentPHIDs')
->setConduitKey('parents')
->setAliases(array('parent', 'parents', 'parentPHID')) ->setAliases(array('parent', 'parents', 'parentPHID'))
->setDescription(pht('Find direct subprojects of specified parents.')), ->setDescription(pht('Find direct subprojects of specified parents.')),
id(new PhabricatorPHIDsSearchField()) id(new PhabricatorPHIDsSearchField())
->setLabel(pht('Ancestor Projects')) ->setLabel(pht('Ancestor Projects'))
->setKey('ancestorPHIDs') ->setKey('ancestorPHIDs')
->setConduitKey('ancestors')
->setAliases(array('ancestor', 'ancestors', 'ancestorPHID')) ->setAliases(array('ancestor', 'ancestors', 'ancestorPHID'))
->setDescription( ->setDescription(
pht('Find all subprojects beneath specified ancestors.')), pht('Find all subprojects beneath specified ancestors.')),