revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-07 12:28:28 +01:00
Code Issues Releases Wiki Activity

Conpherence - fix a bug where users have no events

Browse source 
Summary: Fixes T8518. Defaulting $events to null creates carnage further down the stack. Instead, default it to array() so foreach, array_select_keys, etc. don't barf.

Test Plan: logic and will ask the reporting user to verify since they can repro 100%

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8518

Differential Revision: https://secure.phabricator.com/D13314
This commit is contained in:
Bob Trahan 2015-06-16 14:38:29 -07:00
parent a3010148e2
commit 281082f4d7
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/conpherence/query/ConpherenceThreadQuery.php
View file

@ -355,6 +355,7 @@ final class ConpherenceThreadQuery
$start_epoch = $epochs['start_epoch']; $start_epoch = $epochs['start_epoch'];
$end_epoch = $epochs['end_epoch']; $end_epoch = $epochs['end_epoch'];
$events = array();
if ($participant_phids) { if ($participant_phids) {
$events = id(new PhabricatorCalendarEventQuery()) $events = id(new PhabricatorCalendarEventQuery())
->setViewer($this->getViewer()) ->setViewer($this->getViewer())
@ -363,8 +364,6 @@ final class ConpherenceThreadQuery
->withDateRange($start_epoch, $end_epoch) ->withDateRange($start_epoch, $end_epoch)
->execute(); ->execute();
$events = mpull($events, null, 'getPHID'); $events = mpull($events, null, 'getPHID');
} else {
$events = null;
} }
$invitees = array(); $invitees = array();