From 2814d340367c4f369aa56e1a51480206adb44702 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 12 Dec 2018 10:57:21 -0800
Subject: [PATCH] Fix a stray qsprintf() in the Herald rules engine when
 recording rule application to objects

Summary: Ref T13217. See PHI1006.

Test Plan: Touched an object with associated Herald rules.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13217

Differential Revision: https://secure.phabricator.com/D19872
---
 src/applications/herald/engine/HeraldEngine.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/herald/engine/HeraldEngine.php b/src/applications/herald/engine/HeraldEngine.php
index 739e83e4e8..d853e3eb9a 100644
--- a/src/applications/herald/engine/HeraldEngine.php
+++ b/src/applications/herald/engine/HeraldEngine.php
@@ -243,9 +243,9 @@ final class HeraldEngine extends Phobject {
         }
         queryfx(
           $conn_w,
-          'INSERT IGNORE INTO %T (phid, ruleID) VALUES %Q',
+          'INSERT IGNORE INTO %T (phid, ruleID) VALUES %LQ',
           HeraldRule::TABLE_RULE_APPLIED,
-          implode(', ', $sql));
+          $sql);
       }
     }
   }